[나은비] sprint11 - #245
Open
nano-mm wants to merge 51 commits into
Hidden character warning
The head ref may contain hidden characters: "\ub098\uc740\ube44-sprint11"
Open
[나은비] sprint11#245nano-mm wants to merge 51 commits into
nano-mm wants to merge 51 commits into
Conversation
feat: 나은비 스프린트 미션 2 1차·2차 구현
feat: Sprint Mission 3 - 기본 요구사항, 심화 요구사항 구현
feat: 스프린트 미션 4 기본 요구사항, 심화 요구사항 구현 - 나은비
feat: sprint5 기본 요구사항&심화 요구사항 구현 - 나은비
eedys1234
self-requested a review
June 15, 2026 12:18
eedys1234
reviewed
Jun 17, 2026
| this.contentType = contentType; | ||
| } | ||
|
|
||
| public void markSuccess() { |
Collaborator
There was a problem hiding this comment.
메서드 시그니처를 통해 의미를 부여한점 👍👍👍
| this.user = user; | ||
| this.channel = channel; | ||
| this.lastReadAt = lastReadAt; | ||
| this.notificationEnabled = notificationEnabled; |
Collaborator
There was a problem hiding this comment.
this.notificationEnabled = Channel.PRIVATE == channel;
이건 어떠실까요?
| @NotNull(message = "새로운 마지막 읽은 시간은 필수입니다") | ||
| @PastOrPresent(message = "마지막 읽은 시간은 현재 또는 과거 시간이어야 합니다") | ||
| Instant newLastReadAt, | ||
| Boolean notificationEnabled |
Collaborator
There was a problem hiding this comment.
별건 아니지만 요구사항에는 newNotificationEnabled로 필드명이 되어있는 것 같습니다.
| org.springframework.security: TRACE | ||
|
|
||
| cache: | ||
| caffeine: |
Collaborator
There was a problem hiding this comment.
cache-names 이 누락된것같습니다.
Collaborator
|
은비님! 병합하려는 브랜치 변경 부탁드려요! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
Spring Event - 파일 업로드 로직 분리하기
Spring Event - 알림 기능 추가하기
비동기 적용하기
비동기 실패 처리하기
캐시 적용하기
심화
Spring Kafka 도입하기
Redis Cache 도입하기
주요 변경사항
스크린샷
멘토에게