Repository navigation
fix: preserve proxy identity across worktrees - #199
Conversation
| 'task-owner:: [[Owner]]\ntask-config-root:: .\ntask-name:: example\n' | ||
| 'task-entrypoint:: mise-tasks/example\n' | ||
| 'task-files:: {"mise-tasks/example":"mise-tasks/example"}\n' | ||
| f'source-link:: https://github.com/owner/{name}/blob/main/mise-tasks/example\n' |
There was a problem hiding this comment.
where did source-link:: frontmatter enter into the system?
There was a problem hiding this comment.
The source-link:: task property was introduced by 1ade5324 define Mise Task entities and references. It is specified in the Mise Task entity Frontmatter section: the executable file or TOML definition, using a review branch/commit during review and the default branch for the maintained implementation.
--AI(gpt-6-unspecified Proxy task import review)
| (source / 'pages/Example.md').write_text( | ||
| 'task-owner:: [[Owner]]\ntask-config-root:: .\ntask-name:: example\n' | ||
| 'task-entrypoint:: mise-tasks/example\n' | ||
| 'task-files:: {"mise-tasks/example":"mise-tasks/example"}\n' |
There was a problem hiding this comment.
Where is the purpose of task-files explained?
There was a problem hiding this comment.
The purpose is specified by the Mise Task companion-file contract. task-files:: maps each source repository-relative implementation file to a destination graph-relative path under mise-tasks/, including the entrypoint and runtime helpers. That contract was added by PR #186 companion task contract.
--AI(gpt-6-unspecified Proxy task import review)
| ~~~ | ||
| - Invoking the source checkout's script imports the current sync implementation along with the entity definition. The destination can then run its imported task for other pages from the same source worktree. | ||
| - The source worktree supplies content while the primary checkout supplies the logical graph name. Code forge URLs point to the selected source branch, or to the commit for a detached worktree. The portable manifest keeps the same source ownership across branches and checkouts. | ||
| - Commit the manifest with the imported pages and task files. Push the source branch and link the source PR as a dependency of the destination PR. After the source PR merges, re-sync with the primary checkout selected as `--source` to update the source URLs to the default branch. |
There was a problem hiding this comment.
Is this where the idea of the "manifest" entered into the system?
There was a problem hiding this comment.
I think it entered earlier, here - https://github.com/codekiln/logseq-encode-garden/pull/186/changes
There was a problem hiding this comment.
Yes, your PR #186 pointer identifies the earlier documentation introduction: 96b332c7 define proxy companion task contract describes the manifest in the Proxy Page entity and sync task reference. PR #188 supplies the task-import implementation. PR #199 then fixes source worktree identity. The illustrated manifest explanation now lists its sections and explains ownership and onward imports.
--AI(gpt-6-unspecified Proxy task import review)
1 participant
A proxy first imported from the registered garden could not refresh from an issue-named source worktree: the worktree directory name changed its Logseq source identity. Sync now reads the chosen worktree while deriving the graph name from the primary checkout at the same repository-relative graph path. Worktree forge URLs name its branch (or commit for detached HEAD), and imports keep their existing ownership across branches.
The repository-relative manifest storage requested by #189 is already on main. This change completes the remaining graph identity behavior and documents how to review dependent source and destination PRs, retain the portable manifest with imported tasks, and refresh source links after merge. Today’s journal already lists both updated definitions.
Validation:
python3 -m unittest discover -s mise-tasks/logseq/entity/proxy/page/tests -qpasses 20 tests. New integration coverage exercises root and nested source graphs, linked source and destination worktrees, changed task content, repeat sync, relocated source/destination clones with tracked manifest/tasks, competing repository rejection, and detached source URLs. The Gitpa PR #12 worker also imported the fixed sync task into its existing proxy garden with stable graph identity and accepted ownership. Commit hooks passed.Closes #189
Dependent consumer: codekiln/gitpa#12