Repository navigation
feat/opt in authorized post - #32
Merged
Merged
Conversation
…ured to do so - this would allow testing against a running local https asp.net application. Default is off, but that's up to the consumer to decide anyway
…ts, make https-invalid-cert test always runnable
- fix some issues - add tests around the fixes
…om a POST request
- AllowPostRequests (boolean) - PostAuthTokens (string)
devonCodeo
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
cache-control: no-storeheader is retrieved, do not allow that request to bere-used by another with the same url. In this way, callers can pass through session identifier cookies and not
have them potentially bleed out to other concurrent requests
AllowPostRequestswhich is false by defaultPostAuthTokens, or, if the user is brave, by setting this to"*". The default setting here is empty, meaning that even if AllowPostRequests is set totrue, POST requests won't be allowed - either tokens must be filled in, or the deployer can actively choose to allow POST requests from anywhere (eg if the service is deployed on a known-safe network with no access from the outside world)I added POST support because where we're using it, issuing a GET request to IRAAS means that the IRAAS fetch has to go through all the intermediate network infrastructure, making it tricky when setting headers - we'd want auth headers, for example, but network agents like cloudflare and nginx will also observe other headers like Host. Instead of trying to get clever with what headers we sent, I figured we could skip the entire round-trip with an authorized POST.