impl: add support for disabling CLI signature verification#564
Merged
Conversation
These options are configurable from the Settings page there is no available shortcut on the main plugin page to discourage the quick disable of CLI verification
The main plugin screen has a quick shortcut for setting whether the user wants to fallback on releases.coder.com for signatures if they are not provided by the main deployment. This checkbox should not be visible if the user wants to disable signature verification altogether.
Signature validation is skipped if the user configured the `disableSignatureVerification` to true.
matifali
approved these changes
Jul 30, 2025
jdomeracki-coder
approved these changes
Jul 30, 2025
jdomeracki-coder
left a comment
jdomeracki-coder
left a comment
Contributor
There was a problem hiding this comment.
Approved albeit one of tests seems to be failing:
https://github.com/coder/jetbrains-coder/actions/runs/16608471311/job/46986425046?pr=564
CoderSettingsTest > Default CLI and signature for Linux ARMV7() FAILED
java.lang.NoSuchMethodError: 'void com.coder.gateway.settings.CoderSettingsState.<init>(java.lang.String, java.lang.String, java.lang.String, boolean, boolean, boolean, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, boolean, java.lang.String, java.lang.String, boolean, java.lang.String, java.lang.String, java.lang.String, java.lang.String, boolean, int, kotlin.jvm.internal.DefaultConstructorMarker)'
at com.coder.gateway.settings.CoderSettingsTest.setUp(CoderSettingsTest.kt:26)
Contributor
Qodana Community for JVM33 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2023.3.2
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
fioan89
added a commit
to coder/coder-jetbrains-toolbox
that referenced
this pull request
Jul 31, 2025
This PR implements a new configurable option to allow users to disable GPG signature verification for downloaded Coder CLI binaries. This feature provides flexibility for environments where signature verification may not be required or where fallback signature sources are not accessible. A new option `disableSignatureVerification` is now available only from the Settings page, with no quick shortcut in the main page to discourage users from quickly disabling this option. The `fallbackOnCoderForSignatures` is hidden/not available for configuration once signature verification is disabled. Additionally a rough draft for developer facing documentation regarding CLI signature verification was added. To make things more consistent with Coder Gateway, the fallback setting is always displayed if signature verification is enabled, we no longer display it only once in the main page. This PR is a port of coder/jetbrains-coder#564 from Coder Gateway. <img width="486" height="746" alt="image" src="https://github.com/user-attachments/assets/eff6f944-57ea-4926-857a-d5c5fd5d3901" /> <img width="486" height="746" alt="image" src="https://github.com/user-attachments/assets/7f1d39da-9777-4d5c-a329-e056fe38bf22" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new configurable option to allow users to disable GPG signature verification for downloaded Coder CLI binaries. This feature provides flexibility for environments where signature verification may not be required or where fallback signature sources are not accessible.
A new option.
disableSignatureVerificationis now available only from the Settings page, with no quick shortcut in the main page to discourage users from quickly disabling this option. ThefallbackOnCoderForSignaturesis hidden/not available for configuration once signature verification is disabled.Additionally a rough draft for developer facing documentation regarding CLI signature verification was added.