impl: prefer agent name over agent id in URI handler#585
Merged
Conversation
Agent name is easier to resolve in jetbrains gateway module
Error reporting should also prefer agent name over the agent id.
Test cases related to agent matching have to be updated now that agent name is preferred over agent id.
Contributor
Qodana Community for JVM34 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2023.3.2
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
Rewrote the entire test to be easier to read and debug.
fioan89
marked this pull request as ready for review
October 1, 2025 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent name is easier to resolve in jetbrains gateway module and provides more safety.
Reported by customer on Zendesk ticket 4391