🤖 fix: make mermaid diagram controls zoom#3433
Merged
Merged
Conversation
Summary:
- Replace Mermaid diagram +/- max-height controls with persisted SVG zoom controls.
- Apply the zoom CSS in both desktop and VS Code webview styles.
- Add a regression test covering zoom state and persistence.
Validation:
- bun test src/browser/features/Messages/Mermaid.test.tsx
- make typecheck
- make lint
- nix shell nixpkgs#shfmt nixpkgs#shellcheck nixpkgs#hadolint -c make static-check
---
_Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `17793{MUX_COSTS_USD:-0.00}`_
<!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=0.00 -->
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3425 by making the Mermaid diagram +/- controls scale the rendered SVG instead of only changing the diagram max-height.
Background
The previous controls changed a persisted max-height value. For diagrams already shorter than that cap, clicking +/- produced no visible change, which made the controls appear broken.
Implementation
Validation
bun test src/browser/features/Messages/Mermaid.test.tsxmake typecheckmake lintnix shell nixpkgs#shfmt nixpkgs#shellcheck nixpkgs#hadolint -c make static-checkRisks
Low. The change is scoped to Mermaid diagram controls and CSS. Existing SVG sanitization and rendering paths are unchanged.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:18011{MUX_COSTS_USD:-0.00}