🤖 fix: prevent duplicate consolidation tooltip#3553
Merged
Conversation
Use the shared portaled tooltip for memory consolidation summaries so native title tooltips do not duplicate the app tooltip or get clipped. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$6.15`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=6.15 -->
Member
Author
|
@codex review |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the memory consolidation footer so its summary hover uses the shared portaled tooltip instead of a native
titletooltip. This leaves only one tooltip visible and lets the app tooltip stack above clipped sidebar containers.Background
The consolidation summary hover was using a native
titleattribute, which produced both the app-styled clipped tooltip and the browser/OS native tooltip. Native tooltips cannot participate in the app z-index stack.Implementation
titleattribute withTooltipIfPresentaround the consolidation status lines.whitespace-pre-line.titleattribute.AGENTS.mdand regenerated built-in skill content.Validation
bun test src/browser/features/RightSidebar/Memory/MemoryTab.test.tsxmake typecheckmake static-check390x640viewport withagent-browser; hovered the consolidation footer and verified the DOM had no native title on the consolidation block, one tooltip surface, and a portaled tooltip wrapper atz-index: 9999.Risks
Low. This is isolated to the memory consolidation footer hover surface and uses the existing shared tooltip primitive already used across the app.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$6.15