🤖 tests: stabilize deep-research fanout test#3554
Merged
Merged
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilizes the deep-research capped fanout unit test by letting that heavy fanout fixture use the production WorkflowRunStore lease timing instead of the 100ms stale-lease setting used by retry-focused fixtures.
Background
The known flaky test
built-in deep-research workflow › caps model-produced deep-research fan-outfailed in merge-queue Unit runs withTimed out acquiring workflow mutation lock: .../events.jsonl.lock. I reproduced the same failure locally by pinning the targeted test to one CPU while running a same-core CPU hog; the short 100ms fixture lease renews every 50ms, which adds lock churn while the test is intentionally persisting many parallel workflow steps.Implementation
The capped fanout test now constructs
WorkflowRunStorewith its default production lease settings, because the test is asserting source/claim fanout caps rather than stale-lease retry behavior. Its per-test timeout is raised to 30s to leave room for CPU-contention repro runs without changing normal runtime.Validation
taskset -c 0plus one same-core CPU hog:Timed out acquiring workflow mutation lock: .../events.jsonl.lock.bun test src/node/services/workflows/builtInWorkflowDefinitions.test.ts -t "caps model-produced deep-research fan-out"bun test src/node/services/workflows/builtInWorkflowDefinitions.test.tsmake static-checkRisks
Low product risk: this is test-only and avoids applying retry-fixture lease timing to a high-concurrency fanout assertion. The broader workflow runtime code is unchanged.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$11.63