🤖 tests: stabilize foreground bash migration test#3556
Merged
Conversation
Wait for actual foreground bash output before sending migration tests to the background, instead of relying on CI-dependent fixed sleeps. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$20.62`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=20.62 -->
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilizes the foreground-to-background bash migration tests by waiting for actual foreground bash output before clicking the simulated background action, instead of relying on a fixed sleep that is too optimistic on Windows CI.
Background
The known Windows flake in
tests/ipc/runtime/backgroundBashDirect.test.tsintermittently returnedOutput so far (0 lines)fromshould migrate foreground bash to background and continue running. A deterministic delayed-output repro showed the same assertion failure when the test backgrounds the process after registration but before the first stdout chunk has reached the foreground output collector.Implementation
bash-outputevent path.sendToBackground.Validation
bun test ./tests/ipc/runtime/backgroundBashDirect.test.tsmake static-check(first combined run saw ESLint killed with exit 137; immediate retry passed)Risks
Low. This is test-only and replaces fixed sleeps with an observable readiness signal from the same bash output stream the UI uses.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$20.62