Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@ export const Experiments: Story = {
<SettingsSectionStory
setup={() =>
setupSettingsStory({
// Explicit off-override: experiment localStorage keys leak between
// stories in the same browser session, so seed the parent off to keep
// the "sub-experiments hidden" assertion order-independent.
// Seed the parent off explicitly so the "sub-experiments hidden"
// assertion does not rely on the experiment's default value.
experiments: { [EXPERIMENT_IDS.MEMORY]: false },
})
}
Expand Down
31 changes: 31 additions & 0 deletions src/browser/features/Settings/Sections/settingsStoryUtils.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { afterEach, beforeEach, describe, expect, test } from "bun:test";
import { installDom } from "../../../../../tests/ui/dom";
import { EXPERIMENT_IDS, getExperimentKey } from "@/common/constants/experiments";
import { resetStorybookPersistedStateForStory, setupSettingsStory } from "./settingsStoryUtils";

describe("SettingsSectionStory", () => {
let restoreDom: (() => void) | null = null;

beforeEach(() => {
restoreDom = installDom();
});

afterEach(() => {
restoreDom?.();
restoreDom = null;
});

test("clears unseeded experiment overrides before story setup", () => {
const key = getExperimentKey(EXPERIMENT_IDS.PROGRAMMATIC_TOOL_CALLING);
window.localStorage.setItem(key, JSON.stringify(true));

resetStorybookPersistedStateForStory();

expect(window.localStorage.getItem(key)).toBeNull();

setupSettingsStory({
experiments: { [EXPERIMENT_IDS.PROGRAMMATIC_TOOL_CALLING]: true },
});
expect(window.localStorage.getItem(key)).toBe(JSON.stringify(true));
});
});
15 changes: 13 additions & 2 deletions src/browser/features/Settings/Sections/settingsStoryUtils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ import { selectWorkspace } from "@/browser/stories/helpers/uiState";
import { createWorkspace, groupWorkspacesByProject } from "@/browser/stories/mocks/workspaces";
import { createMockORPCClient } from "@/browser/stories/mocks/orpc";
import { getProvidersConfigStore } from "@/browser/stores/ProvidersConfigStore";
import { getExperimentKey, type ExperimentId } from "@/common/constants/experiments";
import {
getExperimentKey,
getExperimentList,
type ExperimentId,
} from "@/common/constants/experiments";
import { SELECTED_WORKSPACE_KEY, UI_THEME_KEY } from "@/common/constants/storage";
import type { ServerAuthSession } from "@/common/orpc/types";
import type { AgentAiDefaults } from "@/common/types/agentAiDefaults";
Expand All @@ -29,10 +33,17 @@ interface SettingsSectionStoryProps {
children: ReactNode;
}

function resetStorybookPersistedStateForStory(): void {
export function resetStorybookPersistedStateForStory(): void {
if (typeof localStorage !== "undefined") {
localStorage.removeItem(SELECTED_WORKSPACE_KEY);
localStorage.setItem(UI_THEME_KEY, JSON.stringify("dark"));

// Chromatic reuses one browser origin across stories, so experiment
// localStorage overrides from one story must not decide another story's
// switch positions. Each story can opt back in through setupSettingsStory().
for (const experiment of getExperimentList()) {
localStorage.removeItem(getExperimentKey(experiment.id));
}
}
}

Expand Down
Loading