Skip to content

🤖 fix: dedupe memory consolidation summaries#3564

Merged
ThomasK33 merged 1 commit into
mainfrom
fix-memory-summary-tooltip
Jun 15, 2026
Merged

🤖 fix: dedupe memory consolidation summaries#3564
ThomasK33 merged 1 commit into
mainfrom
fix-memory-summary-tooltip

Conversation

@ThomasK33

@ThomasK33 ThomasK33 commented Jun 15, 2026

Copy link
Copy Markdown
Member

Summary

Deduplicates identical memory-consolidation summaries in the Memory tab tooltip while preserving the separate Workspace, Project, and Global status lines. Also fixes the latest-main compaction epoch reader regression that surfaced when the PR entered the merge queue.

Background

A single consolidation pass can cover workspace, project, and global memory scopes. When those status records share the same summary, the footer tooltip repeated the same text once per scope, which made the UI look broken.

After rebasing onto the latest main, merge-queue Unit runs exposed that HistoryService.getMessagesForCompactionEpoch was passing a workspace id into a file-path iterator. That made compaction harvest tests fail on main/merge-group runs because the summary row was never found.

Implementation

  • Added a small helper that trims and deduplicates consolidation summary lines before building the tooltip body.
  • Kept the visible per-scope status metadata unchanged so users can still see which scopes were covered.
  • Updated the compaction epoch reader to iterate full workspace history, including sealed archives and active chat history.
  • Added a MemoryTab regression test for identical workspace/project/global summaries.

Validation

  • bun test src/browser/features/RightSidebar/Memory/MemoryTab.test.tsx
  • bun test src/node/services/historyService.test.ts --test-name-pattern "getMessagesForCompactionEpoch"
  • bun test src/node/services/memoryConsolidationService.test.ts --test-name-pattern "harvest|post-harvest|re-harvest|retryable"
  • make typecheck
  • MUX_ESLINT_CONCURRENCY=1 make lint
  • make fmt-check
  • MUX_ESLINT_CONCURRENCY=1 make static-check

Risks

Low to medium. The tooltip change only affects memory consolidation status rendering. The HistoryService fix restores the intended full-history iteration path used by compaction harvesting; regression coverage already existed and now passes again.


Generated with mux • Model: openai:gpt-5.5 • Thinking: xhigh • Cost: $3.54

@ThomasK33

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 4d7512ed5a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ThomasK33 ThomasK33 force-pushed the fix-memory-summary-tooltip branch from 4d7512e to 18fdb54 Compare June 15, 2026 17:25
@ThomasK33

Copy link
Copy Markdown
Member Author

@codex review

Pushed a CI-only test-selector fix after the Unit job exposed that full-suite Radix tooltip rendering can be inline rather than wrapped by the popper content attribute.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 18fdb543ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ThomasK33 ThomasK33 added this pull request to the merge queue Jun 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 15, 2026
@ThomasK33 ThomasK33 added this pull request to the merge queue Jun 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 15, 2026
@ThomasK33 ThomasK33 added this pull request to the merge queue Jun 15, 2026
Avoid repeating identical consolidation summaries when one run covers workspace, project, and global memory scopes.

---

Generated with mux. Model: openai:gpt-5.5. Thinking: xhigh. Cost: 3.54.
@ThomasK33 ThomasK33 removed this pull request from the merge queue due to a manual request Jun 15, 2026
@ThomasK33 ThomasK33 force-pushed the fix-memory-summary-tooltip branch from 18fdb54 to 6606114 Compare June 15, 2026 18:15
@ThomasK33

Copy link
Copy Markdown
Member Author

@codex review

Rebased onto latest main and added a targeted HistoryService fix for the merge-queue Unit failures: compaction epoch reads now iterate full workspace history instead of passing a workspace id to the file-path iterator.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 6606114b9d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ThomasK33 ThomasK33 added this pull request to the merge queue Jun 15, 2026
Merged via the queue into main with commit 39a07fa Jun 15, 2026
23 checks passed
@ThomasK33 ThomasK33 deleted the fix-memory-summary-tooltip branch June 15, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant