🤖 fix: clarify simplify workflow git context#3570
Merged
Merged
Conversation
Clarify that simplify workflow Git context is captured from the parent workflow checkout before child agent workspaces are spawned, so branch/upstream metadata refers to the reviewed parent branch. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$9.67`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=9.67 -->
Deduplicate combined untracked path metadata and remove redundant leading newlines from simplify prompt sections. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$9.67`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=9.67 -->
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies simplify workflow Git context provenance so child review prompts explain that branch/upstream metadata comes from the reviewed parent checkout, not necessarily the spawned child agent branch. Also applies the simplify workflow's self-review cleanup findings for prompt spacing and duplicated untracked-path handling.
Background
A simplify review prompt showed a generated branch name that looked wrong from the child agent's perspective. The built-in Git actions were reporting the parent workflow checkout correctly, but the prompt did not make that provenance explicit.
Implementation
gitContextSource: "parent-workflow-checkout"field to simplify review context JSON.join("\n\n").git.statusandgit.changedFiles.Validation
workflow_run simplify --helpcompleted successfully.workflow_run simplifycompleted and applied the cleanup commit.bun .mux/workflows/simplify.jspassed.bunx prettier --check .mux/workflows/simplify.jspassed.MUX_ESLINT_CONCURRENCY=1 make static-checkpassed locally before pushing.Risks
Low. This changes a project workflow prompt and small metadata helpers only; runtime Git action semantics are unchanged.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$15.69