🤖 tests: stabilize WorkflowService background interrupts#3573
Merged
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilizes WorkflowService unit coverage by removing a race in the foreground run-created callback test and treating user-interrupted background workflow exits as expected cancellations rather than background failures.
Background
Recent unit CI runs showed
WorkflowService > notifies foreground run creation before the first workflow step blocksintermittently receiving bothrun-createdandagent-startedbefore the polling assertion ran. The service already awaitedonRunCreated; the test was racing the runner after a synchronous callback returned.The same CI window also showed noisy expected background-interrupt stack traces immediately before workflow tests continued. User interruptions should not be logged as background failures, but terminal callbacks that explicitly request interrupted notifications should still be delivered.
Implementation
onRunCreatedcallback in the flaky test so the assertion checks the intended service ordering deterministically.interruptedstatus before deciding whether to log a failure.console.errornoise.Validation
bun test --max-concurrency=1 --coverage --coverage-reporter=lcov src/node/services/workflows/WorkflowService.test.tsMUX_ESLINT_CONCURRENCY=1 make static-checkRisks
Low. The production change is scoped to WorkflowService background failure reporting after an explicit interrupt. Non-interrupted background failures still log and notify as before.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$32.88