🤖 fix: keep workflow progress visible#3584
Conversation
Deduplicate the pending workflow run attachment lookup in StreamManager completeToolCall while preserving existing and fallback attachment behavior.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 033adfb2ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed Codex finding |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1973a4788
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed Codex finding |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Pushed a CI unit-test fix after reproducing the failing Validation rerun locally:
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82eb3926a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed Codex finding |
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Updated the card layout per feedback so Arguments and Definition source render before Workflow events again, while keeping the durable workflow attachment race fix intact. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Fix workflow run cards that could show only invocation arguments instead of the live workflow action/task list. The card now preserves the preferred
Arguments/Definition sourceordering while stream attachment persistence hydrates the durable workflow run as soon as the backend creates or replays it.Background
Foreground workflow tools can create a durable workflow run before the streamed dynamic tool part is stored. When that attachment races ahead of the tool part, the renderer can miss the exact
runIdhint and render an arguments-only card instead of the useful list of workflow actions/tasks.Implementation
StreamManagerwhen the attachment event races ahead of the tool part, then apply the exact run attachment when the matching tool part is persisted or completed.workflow-run-attachedthroughAIService, so reconnect/full-replay renderers rebuild exact workflow hints.ArgumentsandDefinition sourcebeforeWorkflow events, with large payloads still collapsed for scanability.simplifyworkflow and applied its cleanup commit to dedupe workflow attachment lookup incompleteToolCall.Validation
bun test src/browser/features/Tools/WorkflowRunToolCall.test.tsxbun test src/node/services/streamManager.test.ts -t "workflow run attachments"bun test src/node/services/aiService.test.ts -t "forwards workflow-run-attached events"make static-checkApp/Chat/Tools/WorkflowRun/RunningBackgroundWithRunat a 375×667 viewport withagent-browser; verifiedArgumentsandDefinition sourcerender aboveWorkflow eventsand captured screenshot/video evidence locally.workflow_run simplify --base origin/main --head HEAD --fixRisks
Medium risk: this touches streaming partial persistence/forwarding and workflow card rendering. The stream-manager change is scoped to workflow-run attachment metadata, and the UI change preserves existing section content while restoring the preferred details-before-events order.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$63.70