🤖 fix: distinguish plan Copy file path button icon#3586
Merged
Conversation
The plan-file display's 'Copy' (content) and 'Copy file path' buttons both used the Clipboard/ClipboardCheck icons, making them visually indistinguishable. Give 'Copy file path' the Copy/Check icons (the repo's copy-a-value idiom, see RuntimeBadge) so it reads as a distinct action from the content Copy button.
Collaborator
Author
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Differentiate the plan-file display's two copy buttons. Follow-up to #3568, which replaced the removed mux.md "Share" link action with a "Copy file path" action — but both that button and the existing "Copy" (content) button used the same
Clipboard/ClipboardCheckicons, making them visually indistinguishable.Background
#3568 removed mux.md link support and, in the plan display, swapped the "Share" link for a "Copy file path" action. Because the new button reused the content button's
Clipboard/ClipboardCheckicons, the two adjacent actions looked identical and only differed by label.Implementation
The "Copy file path" button now uses lucide's
Copy/Checkicons — the repo's existing copy-a-value idiom (seeRuntimeBadge, which copies workspace paths) — while the content "Copy" button keepsClipboard/ClipboardCheck. The two buttons now read as distinct actions at rest and in their copied state.Risks
Minimal — icon-only change in
ProposePlanToolCall.tsx. No behavior, props, or copy-to-clipboard logic changed.Generated with
mux• Model:anthropic:claude-opus-4-8• Thinking:xhigh• Cost:$25.12