Skip to content

Manual approval should remove rejected #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeykazakov merged 1 commit into from
Jul 3, 2026
Merged

Manual approval should remove rejected #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/states/state_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ func SetApprovedManually(userSignup *toolchainv1alpha1.UserSignup, approved bool
setState(userSignup, toolchainv1alpha1.UserSignupStateVerificationRequired, false)
setState(userSignup, toolchainv1alpha1.UserSignupStateDeactivating, false)
setState(userSignup, toolchainv1alpha1.UserSignupStateDeactivated, false)
setState(userSignup, toolchainv1alpha1.UserSignupStateRejected, false)
}
}

Expand Down
8 changes: 8 additions & 0 deletions pkg/states/state_manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,14 @@ func TestStateManager(t *testing.T) {

// Setting approved should remove deactivating
require.False(t, Deactivating(u))

SetApprovedManually(u, false)

SetRejected(u, true)
SetApprovedManually(u, true)

// Setting approved should remove rejected
require.False(t, Rejected(u))
})

t.Run("test verification required", func(t *testing.T) {
Expand Down
Loading