Issue 2 create navbar component#15
Merged
Merged
Conversation
SafetyInObscurity
requested changes
Nov 24, 2025
SafetyInObscurity
left a comment
SafetyInObscurity
left a comment
Collaborator
There was a problem hiding this comment.
A good start, but there's still some polish to go.
| <> | ||
| <header className="fixed left-0 top-0 z-50 w-full border-b border-border/20 bg-[#090A19] font-jersey10"> | ||
| <div className="mx-auto max-w-[1440px] rounded-[5px] px-20"> | ||
| <div className="flex h-[104px] items-center justify-between"> |
Collaborator
There was a problem hiding this comment.
There's not much use having these two divs. Their styling can just be applied to the header that contains them.
laurenpudz
previously requested changes
Nov 28, 2025
SafetyInObscurity
approved these changes
Nov 29, 2025
SafetyInObscurity
left a comment
SafetyInObscurity
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Thanks for the hard work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Change Form
Other Information
N/A
Related issue