Issue 16 create progress bar component#39
Merged
Conversation
…ssue-3-Create_navigation_bar_component
…ep I would like do something about layout
junhyap
requested changes
Jul 19, 2025
junhyap
left a comment
junhyap
left a comment
Member
There was a problem hiding this comment.
Good job! Just have some comments. Feel free to let me know your thoughts :)
Julie-Salazar
requested changes
Jul 19, 2025
Julie-Salazar
left a comment
Julie-Salazar
left a comment
Collaborator
There was a problem hiding this comment.
Hello please review the comments that Jun has left behind and after that we can approve merge @survivzhang
Contributor
Author
|
Have some other improvements as well, will push after I testing new features 发自我的 iPhone在 2025年7月19日，16:58，Jules :) ***@***.***> 写道：
@Julie-Salazar requested changes on this pull request.
Hello please review the comments that Jun has left behind and after that we can approve merge @survivzhang
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Contributor
Author
|
Done, please check |
Julie-Salazar
previously approved these changes
Jul 21, 2025
Julie-Salazar
left a comment
Julie-Salazar
left a comment
Collaborator
There was a problem hiding this comment.
looks good to me! good job on routing the pages as well
Collaborator
|
please make sure you resolve issues and you should be good to merge it yourself as I already approved it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
[Briefly summarise the changes that you made. Just high-level stuff]
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
[Is there anything in particular in the review that I should be aware of?]