59-connect-leaderboard-and-matchdetails-to-backend#60
Merged
Conversation
ErikaKK
reviewed
Jul 22, 2025
ErikaKK
left a comment
ErikaKK
left a comment
Contributor
There was a problem hiding this comment.
The name of match-details.tsx and matchdetails.tsx are very similar. Are they the best naming? Do you have route to go to matchdetails.tsx page? I didn't see it.
Contributor
Author
ah yeah, I forgot to delete the matchdetails. since format-rules and sponsor-guest are using dash. I just follow match-details. I will delete the matchdetails.tsx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
[Briefly summarise the changes that you made. Just high-level stuff]
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
related to issue #59