Skip to content

Auto email reminder for membership renewal#1631

Merged
ErikaKK merged 6 commits into
masterfrom
auto-email-reminder
Aug 2, 2025
Merged

Auto email reminder for membership renewal#1631
ErikaKK merged 6 commits into
masterfrom
auto-email-reminder

Conversation

@ErikaKK

@ErikaKK ErikaKK commented Aug 2, 2025

Copy link
Copy Markdown
Contributor

Change Summary

[Briefly summarise the changes that you made. Just high-level stuff]

  • Cron jobs tested.
  • Resend can only send 100 emails per day so I set 4 reminder job assuming we will have 300-400 members:)
  • Added a column in user table
image

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

@vercel

vercel Bot commented Aug 2, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2025 11:05am

@ErikaKK ErikaKK changed the title Auto email reminder Auto email reminder for membership renewal Aug 2, 2025
@ErikaKK ErikaKK requested a review from dct0 August 2, 2025 03:18

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is the cron key handled :0 would it fail if the env variables aren't defined here? not entirely sure since i haven't done something like this before

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's defined in vercel env variables

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks really good 👍

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm publishing the schema shouldn't be sus i think... so ye looks ok, we just need to be safe about other sensitive data

@Julie-Salazar Julie-Salazar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!
We currently have like 400ish rows on db, could do only updating reminder_pending to false after successful email send and this might make it easier to keep track of resend

@ErikaKK

ErikaKK commented Aug 2, 2025

Copy link
Copy Markdown
Contributor Author

Looks good!! We currently have like 400ish rows on db, could do only updating reminder_pending to false after successful email send and this might make it easier to keep track of resend

That is a good point. Thank you!

@ErikaKK ErikaKK merged commit d217e1f into master Aug 2, 2025
13 checks passed
@ErikaKK ErikaKK deleted the auto-email-reminder branch August 2, 2025 11:52
@ErikaKK ErikaKK linked an issue Aug 10, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subscribe feature in emails

2 participants