Conversation
…pdate `ResultExtensions` logic, and introduce test project for WebApi functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new test project for the
Coderynx.Functional.WebApipackage and improves the handling of HTTP results for functional result types. It adds comprehensive unit tests for bothResultandOptionextension methods, fixes a logic bug in the result-to-HTTP mapping, and ensures proper HTTP status codes and problem details are returned for different error kinds. The package version is also incremented for release.Testing and Project Structure:
Coderynx.Functional.WebApi.Teststargeting .NET 9, including dependencies for xUnit and code coverage, and registered it in the solution file. [1] [2]ResultExtensionsandOptionExtensions, covering all major success and error scenarios for HTTP result mapping. [1] [2]Bug Fixes and Improvements in HTTP Result Mapping:
ToHttpResult<TValue>where the check forresult.Valuewas inverted, ensuring correct HTTP responses for null and non-null values.ErrorKind.InvalidInputto the appropriate RFC link and HTTP 400 status code in problem responses. [1] [2]Versioning: