Conversation
… bump version to 1.4.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way HTTP results are generated from
Resultobjects in theResultExtensionsclass, improving code clarity and separation of concerns. The main change is replacing the internal helper method with more explicit methods for handling success and error cases, making the code easier to read and maintain. The package version is also incremented.Refactoring HTTP result generation
ToHttpResultInternalhelper with two explicit methods:ToHttpSuccessResultfor successful results andToHttpErrorResultfor failures, simplifying the logic inToHttpResultoverloads. [1] [2] [3] [4]ToHttpResultoverloads to use the new explicit methods, ensuring failures are handled byToHttpErrorResultand successes byToHttpSuccessResult. [1] [2] [3]Version update
1.4.3to1.4.4inversion.json.