🧹 [code health improvement] Prevent deletion of problems referenced by assignments - #44
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎯 What: This PR addresses a
TODOby implementing safety checks to prevent deleting a problem that is currently referenced by active assignments or assignment groups.💡 Why: Deleting a problem referenced by active tasks or groups leads to broken states, orphaned data, and cascading failures in the assignment tracking system. Adding checks guarantees relational integrity and system stability.
✅ Verification: Added queries to
assignment.sqlandproblem.sql. VerifiedProblemIdsvsProblemIDsgeneration correctly mapped back withsqlc.argfix. Tests for both problem and assignment domains compile and pass successfully.✨ Result: Safe
DeleteProblembehaviour. Archiving is only permitted when the problem has no active dependencies.PR created automatically by Jules for task 17706797555714192398 started by @Gautam7352