implemented queue - #13
Open
codesankalp wants to merge 5 commits into
Open
Conversation
devkapilbansal
requested changes
Sep 14, 2020
devkapilbansal
left a comment
devkapilbansal
left a comment
Collaborator
There was a problem hiding this comment.
Also add single line comments to explain your code
| def __init__(self, value): | ||
| self.value = value | ||
| self.next = None | ||
|
|
Collaborator
There was a problem hiding this comment.
Why this extra line?
| if self.head is None: | ||
| self.head = new_node | ||
| self.tail = self.head | ||
| else: |
Collaborator
There was a problem hiding this comment.
Please use 4 spaces or single tab for indentation.
| self.num_elements += 1 | ||
|
|
||
| def dequeue(self): | ||
| if self.is_empty(): |
Collaborator
There was a problem hiding this comment.
Please add what this function is doing so that other contributors don't found it difficult
close #3 added methods like enqueue and dequeue and much more.
Comment on lines
+42
to
+44
|
|
||
| if __name__ == '__main__': | ||
| unittest.main() |
Collaborator
There was a problem hiding this comment.
Remove this driver code
Owner
Author
There was a problem hiding this comment.
iske liye bhi issue banata hu me.
Collaborator
There was a problem hiding this comment.
No, just remove this. I have made changes in others
Added insert_start function for Doubly Linked List
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #3
added methods like enqueue and dequeue and much more.
tests:-
