Skip to content

Create traversals.py - #32

Open
Pratik-ahirrao wants to merge 1 commit into
codesankalp:masterfrom
Pratik-ahirrao:patch-1
Open

Create traversals.py#32
Pratik-ahirrao wants to merge 1 commit into
codesankalp:masterfrom
Pratik-ahirrao:patch-1

Conversation

@Pratik-ahirrao

Copy link
Copy Markdown

No description provided.

@Pratik-ahirrao

Copy link
Copy Markdown
Author

Please keep label as hacktoberFest so that this commit can be counted as one of my 4 prs for hacktoberFest

@Aryamanz29

Copy link
Copy Markdown
Collaborator

Please keep label as hacktoberFest so that this commit can be counted as one of my 4 prs for hacktoberFest

Write test cases for transversal.py. Test file should be named as "test_transversal.py" in dsalgo/tests and give a proper description of your PR.

@Aryamanz29

Aryamanz29 commented Sep 25, 2020

Copy link
Copy Markdown
Collaborator

Please keep label as hacktoberFest so that this commit can be counted as one of my 4 prs for hacktoberFest

Add docstrings to specify - params of your functions & its description use pep -8 coding style (ref:- contributing.md)
https://www.python.org/dev/peps/pep-0008/

Comment thread dsalgo/traversals.py
self.right = None
self.val = key


Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there are no many blank lines??

@devkapilbansal devkapilbansal Sep 26, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pratik-ahirrao Can you please comment your code too? It is very difficult to understand what the code is doing

@codesankalp

codesankalp commented Sep 28, 2020

Copy link
Copy Markdown
Owner

@Pratik-ahirrao we will not approve your pull request until it's linked with an issue.
Linking the issue with pull request is a must step.
Also make the code changes as mentioned by @devkapilbansal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants