Skip to content

Linked list implementation in python - #64

Open
AnshMishra2001 wants to merge 5 commits into
codesankalp:masterfrom
AnshMishra2001:master
Open

Linked list implementation in python#64
AnshMishra2001 wants to merge 5 commits into
codesankalp:masterfrom
AnshMishra2001:master

Conversation

@AnshMishra2001

@AnshMishra2001 AnshMishra2001 commented Oct 2, 2020

Copy link
Copy Markdown

Description

Related Issue

Fixes #40

Type of Change:

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)

Motivation and Context

How Has This Been Tested?

Checklist:

  • I read the CONTRIBUTING document before making this pull request
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

@devkapilbansal

Copy link
Copy Markdown
Collaborator

Hi, @AnshMishra2001 please update the above comment with relevant details.

@devkapilbansal

Copy link
Copy Markdown
Collaborator

@codesankalp do we need this??

@codesankalp

Copy link
Copy Markdown
Owner

@AnshMishra2001 you need to add all the methods in the dsalgo/linked_list.py
we don't need to re-implement the linked list.
You haven't linked your issue with the pr also.
Also, there are so many code-inline comments in your file.
If you changed all the mentioned things within 2 days your pull request will be marked as valid and accepted else it will be considered as spam.
See our contributing guidelines also.

@codesankalp codesankalp left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all the extra things from this file.
Only include the mentioned functions.

@devkapilbansal

Copy link
Copy Markdown
Collaborator

@AnshMishra2001 are you working on this?

@AnshMishra2001

Copy link
Copy Markdown
Author

Yes! I'll complete it soon

@AnshMishra2001

Copy link
Copy Markdown
Author

Changes made in #40

Comment thread dsalgo/linked_list.py Outdated
# Loop ends

return head
def Circular(head):

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change C into c

Comment thread dsalgo/linked_list.py
return(node==head)

def is_Palindrome(s):

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle the exception also i.e. for numbers.

Comment thread dsalgo/linkedlist.py Outdated

p.next = self.head
self.head = p
prev.next = None No newline at end of file

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a newline at the end of file

@codesankalp

Copy link
Copy Markdown
Owner

Also squash your commits into one.

@codesankalp

Copy link
Copy Markdown
Owner

Please do the mentioned changes earlier and rebase your branch to avoid merge conflicts.
If you are not working on this then tell me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement linked list algorithms in linked_list.py

3 participants