fix(engine): keep turn and submission attribution on TurnComplete

[asto18089]

What

Terminal events lost their attribution. The internal TurnComplete carried no turn id, the wire event's turn_id was documented as filled "from the envelope when it knows it" and the in-process projection hardcoded None, preflight rejections (route-install failure, edit_last_turn rejections) emitted bare unattributed terminals, and the turn_end hooks lifecycle reported runtime_turn_id — a stale-surviving id that is not an authority for a later TurnComplete. Hosts correlating a submission with its outcome had to compensate heuristically.

TurnComplete now carries its attribution end to end:

• internal Event::TurnComplete gains turn_id, submission_id, compaction_id;
• wire EventMsg::TurnComplete gains submission_id and compaction_id (serde-default, absent in older producers — strictly additive; no existing field changes);
• turn_id is the actually started turn, absent when a submitted operation fails before starting;
• submission_id is the host submission correlation, including preflight rejection; runtime self-starts do not carry a host token;
• compaction_id is the manual compaction operation identity, never the surrounding host submission;
• the parity projection forwards all three, the UI's turn_end lifecycle receipt uses the terminal event's attribution when present (the U02-07 ownership heuristic remains only for absent attribution), and remote-control/ACP runtimes pass it through.

Tests

• Protocol: additive round-trip (turn_complete_ownership_is_additive_and_round_trips) — old JSON without the fields decodes, new fields serialize only when present; full protocol suite green.
• Engine: started turns echo their attribution, preflight rejections carry the submission id with no turn id, queued/manual compaction terminals keep their operation id, self-starts stay None.
• UI/runtime-threads: the lifecycle receipt uses the terminal event's owner; stale runtime_turn_id no longer leaks into receipts.
• cargo test -p codewhale-tui --lib targeted filters green (turn_complete, submission_id, terminal_correlation, runtime_threads 290 passed); clippy -D warnings clean (tui lib + protocol).

Ported from the Pinvou/CodeWhale fork (#97 by @zhuowp), re-expressed on the current engine (pre-admitted turns, parent_route_usage fields).

Refs #6557

[claude]

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

[Hmbown]

🤖 This reply is from Claude Opus 5.5, an AI agent working on behalf of the Codewhale maintainers. It is posted through @Hmbown's account, but Hunter did not write it.

Merged in ebc86e6. Thank you @asto18089. Terminal events now carry their own turn_id, submission_id and compaction_id. The two exits that sent no terminal at all now do: a route that fails to install, and a manual compaction whose route is rejected. Before, callers waiting on TurnComplete could hang on those, and the TUI's turn_end receipt borrowed the previous turn's id.

Follow-up on main (7c3828d):

• docs/ARCHITECTURE.md now names which pre-start rejections emit a failed terminal: route install and edit_last_turn. The image and constitution rejections in handle_send_message still emit only Error, and the old wording would have had a host wait for a terminal that never comes.
• The event-loop comment that said TurnComplete carries no turn id now says the U02-07 heuristic stays because TUI dispatches carry no submission id.
• The generated web agent docs are regenerated, because they embed ARCHITECTURE.md.

Not in a release yet. The new ids are not used for loading ownership yet; that remains #6557.

— Written by Claude Opus 5.5 (AI agent) on behalf of the maintainers.