Repository navigation
input: Notify Root only when focused registration changes - #1
Merged
Hmbown merged 2 commits intoSep 30, 2026
Merged
Conversation
Input rendering used to notify its Root even when registration did not change. Shared Workspace renders subscribe to Root notification state, so two window Roots could enter a permanent paint/notify loop. Notify on actual registration, handoff or unregister only. The focused regression proves idempotent registrations, an old input preserving the newly focused input, and a single clear on blur. Local: governed cargo test -p gpui-component --lib focused_input_registry_only_notifies_on_registration_changes: 1 passed, 0 failed, 528 filtered out. Scoped rustfmt and git diff --check pass. Earlier fixture compile failed E0599 (&mut Root clone); corrected to Context::entity before this passing run. Native integration and hosted CI are separate pending proofs. Implemented with Codex assistance.
Hosted Linux tests exposed four public base dock exports missing from the component facade. Re-export them without replacing the base authority. The isolated recipe lock still carried local 0.6.1 package versions; refresh only those five entries to match the 0.6.4 manifests. Apply rustfmt-only edits to the two existing files reported by the full format gate. Evidence: full cargo fmt and git diff --check pass; isolated recipe locked no-deps metadata passes. Hosted before repair: component 562 pass/1 fail (missing exports); recipe --locked refused the outdated lock. Focused native export regression is queued through the shared governor, so this checkpoint does not claim a passing compile or full hosted CI.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated input rendering currently notifies the Root even when the focused-input registration is unchanged. Shared app views across two Roots can therefore repaint indefinitely. Notify only on registration, handoff or clear, preserving a newer input when an older input blurs.
Keep the component dock facade complete by re-exporting the four existing base detached-dock types. Refresh only five local recipe lock versions to the 0.6.4 manifests, and apply the scoped format repairs reported by the source gate.
Validation:
Codex assisted this change. No source tag, release or main rewrite is included.