-
Notifications
You must be signed in to change notification settings - Fork 1
date picker #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alissav30
wants to merge
11
commits into
main
Choose a base branch
from
alissa-branch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
date picker #68
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
af03f28
quick styling fix
alissav30 4c8217a
Squashed commit of the following:
alissav30 2adf7f1
Merge branch 'main' into alissa-branch
alissav30 207dccc
fixed date picker
alissav30 38e2144
another styling fix on the date picker
alissav30 2c75b28
generalizing take 1
alissav30 39fb474
Moving in the direction of a solution
pjames27 d67e80e
up to date with main
alissav30 e5b4fe4
revert back date picker
alissav30 5437433
some more generalization updates
alissav30 0f74fdd
generalizing logic
alissav30 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,43 +29,51 @@ export default function InputSelectButtons< | |
| canDeselect = true, | ||
| options, | ||
| }: InputSelectButtons_Input<TOptions, TValue>) { | ||
| const isSelected = (opt: TOptions[number]) => | ||
| Array.isArray(value) | ||
| ? value.some((v) => v.id === opt.id) | ||
| : value && value.id === opt.id; | ||
| const isSelected = (opt: TOptions[number]) => { | ||
| const optionKey = opt.id || opt.value; // Assuming all options have either an id or value | ||
| return Array.isArray(value) | ||
| ? value.some((v) => v.id === optionKey || v.label === optionKey) | ||
| : value && (value.id === optionKey || value.label === optionKey); | ||
| }; | ||
|
|
||
| console.log("Current value in InputSelectButtons: ", value); | ||
|
|
||
|
|
||
|
|
||
| return ( | ||
| <div className="flex gap-3 flex-wrap"> | ||
| {options.map((opt) => ( | ||
| <Button | ||
| key={opt.id} | ||
| className={classNames("-uppercase", [ | ||
| isSelected(opt), | ||
| "bg-blue-200 hover:bg-blue-100", | ||
| ])} | ||
| disabled={opt?.specialStatus === "disabled"} | ||
| onClick={() => { | ||
| if (opt.specialStatus === "disabled") return; | ||
| if (isSelected(opt) && canDeselect) { | ||
| // Now unselect | ||
| onChange?.( | ||
| (Array.isArray(value) | ||
| ? Object.freeze(value.filter((v) => v.id !== opt.id)) | ||
| : null) as TValue, | ||
| ); | ||
| } else { | ||
| onChange?.( | ||
| (Array.isArray(value) | ||
| {options.map((opt) => { | ||
| const optKey = opt.id || opt.value; // Handle options with id or value | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above |
||
| isSelected(opt) ? console.log("isSelected(opt) is true", opt.label) : console.log(""); | ||
| return ( | ||
| <Button | ||
| key={optKey} | ||
| className={classNames("-uppercase", [ | ||
| isSelected(opt), | ||
| "bg-blue-200 hover:bg-blue-100", | ||
| ])} | ||
| disabled={opt.specialStatus === "disabled"} | ||
| onClick={() => { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should move this outside of the return statement into a useCallback hook. |
||
| if (opt.specialStatus === "disabled") return; | ||
| const isOptSelected = isSelected(opt); | ||
| if (isOptSelected && canDeselect) { | ||
| const newValue = Array.isArray(value) | ||
| ? Object.freeze(value.filter((v) => v.id !== optKey && v.value !== optKey)) | ||
| : null; | ||
| onChange?.(newValue as TValue); | ||
| } else { | ||
| const newValue = Array.isArray(value) | ||
| ? [...value, opt] | ||
| : opt) as unknown as TValue, | ||
| ); | ||
| } | ||
| onBlur?.(); | ||
| }} | ||
| > | ||
| {opt.label} | ||
| </Button> | ||
| ))} | ||
| : opt; | ||
| onChange?.(newValue as unknown as TValue); | ||
| } | ||
| onBlur?.(); | ||
| }} | ||
| > | ||
| {opt.label} | ||
| </Button> | ||
| ); | ||
| })} | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need to not force every option to have an ID and use this?