chore(android): drop the stale compileSdk suppression - #9
Merged
Conversation
`android.suppressUnsupportedCompileSdk=35` and its comment were left over from AGP 8.3, which was only validated up to compileSdk 34. Both the premise and the value are now wrong: the project is on AGP 8.13.2 and compileSdk 36, so the property targets a version we no longer compile against, and AGP 8.13 supports 36 natively with no warning to suppress. It was inert rather than harmful, but it read as documentation of a constraint that no longer exists. Verified by building with it removed: `assembleDebug` succeeds with zero untested-SDK warnings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
android.suppressUnsupportedCompileSdk=35and its comment fromandroid/gradle.properties.Why
Both the premise and the value are now wrong. The comment reads:
After #8 the project is on AGP 8.13.2 and compileSdk 36. So:
35, which is no longer the compileSdk, meaning it wouldn't suppress anything even if there were a warning.Leftover from the API 36 upgrade; it was inert rather than harmful, which is why it survived that PR.
Verification
android/gradlew -p android assembleDebugwith the line removed: BUILD SUCCESSFUL, zero untested-SDK warnings. CI covers the rest.🤖 Generated with Claude Code