fix: parse wrangler.jsonc as JSONC in the production config projection - #12
Merged
Conversation
The committed Wrangler configuration gained comments, but the production deploy path still read it with JSON.parse, so every deploy:production run failed before reaching Wrangler. Parse it with jsonc-parser and cover the committed file itself so the projection cannot drift from the source format again. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The committed Wrangler configuration gained comments in #11, but the production deploy path still read it with
JSON.parse, so everydeploy:productionrun failed before reaching Wrangler.jsonc-parser(new dev dependency of@able/desk, per the package-first policy) and reject invalid or non-object JSONC.wrangler.jsoncitself in the projection tests so the deploy path can never drift from the source format again, alongside an invalid-source rejection test.npm run checkpasses, and a local dry run ofbuild:production-configproduces a correct projection for a predecessor-named Worker.🤖 Generated with Claude Code