Skip to content

fix: improving to-array #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Farenheith wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: improving to-array #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/augmentative-iterable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,7 @@ function augmentativeForEach(

function augmentativeToArray() {
const result = [];

augmentativeForEach.call(this, result.push.bind(result));

for (const item of this) result.push(item);
return result;
}

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "augmentative-iterable",
"description": "This project is just a template for creation of new projects",
"version": "1.6.0",
"version": "1.6.1",
"private": false,
"author": {
"name": "Thiago O Santos <tos.oliveira@gmail.com>"
Expand Down
5 changes: 3 additions & 2 deletions test/unit/iterable.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
addMapAsync,
flatMapIterable,
skipIterable,
augmentativeToArrayAsync,
} from '../../index';
import { expect } from 'chai';
import { stub } from 'sinon';
Expand Down Expand Up @@ -254,7 +255,7 @@ describe('Iterable', () => {
expect(result).to.be.eql([2, 3]);
});

it('should respect filter and takeWhile through operations', () => {
it('should respect filter and takeWhile through operations', async () => {
const callFilter = stub().callsFake((x) => x !== 2);
const callTakeWhile = stub().callsFake((x) => x < 4);
const callMap = stub().callsFake((x) => x);
Expand All @@ -263,7 +264,7 @@ describe('Iterable', () => {
const takeWhile = addTakeWhile(filter, callTakeWhile);
const map: any = addMapAsync(takeWhile, callMap);

const result = augmentativeToArray.call(map);
const result = await augmentativeToArrayAsync.call(map);

expect(result).to.be.eql([1, 3]);
expect(callFilter).to.have.callsLike([1], [2], [3], [4]);
Expand Down