Skip to content

fix issue related to searching town postcodes with no street or district data #3 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pedropenna wants to merge 1 commit into
base: master
Choose a base branch
from
+44 −10
Open

fix issue related to searching town postcodes with no street or district data #3 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions lib/scraper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,18 +161,32 @@
var data = html('.caixacampobranco,.caixacampoazul');

data.each(function() {

var address = $(this).find('.respostadestaque');

response.data.push({
'address': parseAddress(address.eq(0).text().trim()),
'district': address.eq(1).text().trim(),
'city': address.eq(2).text().trim().split('/')[0].trim(),
'state': address.eq(2).text().trim().split('/')[1].trim(),
'postcode': parsePostcode(address.eq(3).text().trim()),
'client': address.eq(4) ? address.eq(4).text().trim() : null
var labels = $(this).find('.resposta');

var parsedResponse = {};
address.each(function(index, element) {
var label = labels.eq(index).text().trim();
var text = $(element).text().trim();

if (label == 'Localidade / UF:'
|| label == 'Localidade/UF:') {
var stateAndCity = text.split('/');
parsedResponse.city = stateAndCity[0].trim();
parsedResponse.state = stateAndCity[1].trim();
} else if (label == 'Bairro:') {
parsedResponse.district = text;
} else if (label == 'Logradouro:'
|| label == 'Endereço:') {
parsedResponse.address = parseAddress(text);
} else if (label == 'CEP:') {
parsedResponse.postcode = parsePostcode(text);
} else if (label == 'Cliente:') {
parsedResponse.client = text;
}
});

response.data.push(parsedResponse);
});

// paging
Expand Down Expand Up @@ -266,4 +280,4 @@

return CEP;

}));
}));
20 changes: 20 additions & 0 deletions test/scraper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,26 @@ describe('Address from Postcode', function() {
});

});

it('should get the city and state data without the fine-grained street and district data from a town postcode', function(done) {

CEP.scrape('34000000', function(res) {
should(res).be.ok;
should(res.data).be.an.Array();
should(res.data).not.be.empty();

var result = res.data[0];

should.not.exist(result.address);
should.not.exist(result.district);
should.equal(result.city, 'Nova Lima', 'City not equal as expected');
should.equal(result.state, 'MG', 'State not equal as expected');

done();
});

});

});


Expand Down