Skip to content

Conversation

@kam193
Copy link
Contributor

@kam193 kam193 commented Apr 19, 2019

When no FEATURE is passed to make test, results of test shouldn't be ignored. At this moment, any test result is ignored and CI can't catch errors - they are stored in log, but not showed in status.

When no FEATURE is passed to make test, results of test
shouldn't be ignored, so CI can work properly
@kam193 kam193 requested review from kawazaki0 and xbend April 19, 2019 08:14
@kawazaki0
Copy link
Contributor

Here is the source of the problem https://github.com/codilime/acid/pull/54/files#diff-b67911656ef5d18c4ae36cb6741b7965L41 . The changed line -SETTINGS_PATH=$(SETTINGS_TEST) FLASK_APP=$(APP) pytest -m unit shouldn't have a dash at the beginning as the original file. Dash is used to ignore exit status from the command, but we want to ignore this status only if the FEATURE is defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants