Fix OSSAR workflow: remove Node 24 opt-in env var and update stale .NET comments#94
Closed
Copilot wants to merge 2 commits into
Closed
Fix OSSAR workflow: remove Node 24 opt-in env var and update stale .NET comments#94Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/codingUnited/MokseWebsite/sessions/9f04dd6d-1eab-4d78-89c2-0ac44c35d01c Co-authored-by: JMG3000 <105582814+JMG3000@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update footer content for better user experience
Fix OSSAR workflow: remove Node 24 opt-in env var and update stale .NET comments
Apr 2, 2026
Contributor
ReviewAll changes have been reviewed and not approved based on the timeline and effectiveness after current the update changes. Status:Not Approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open review comments on the OSSAR workflow pointed out two issues: a broad Node 24 opt-in that could silently break incompatible actions, and .NET guidance comments referencing the deprecated Security Code Analysis CLI and EOL .NET Core 3.1.x.
Changes
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24— drops theenv:block that forced all JS-based actions in the job onto Node 24, which is unsafe for actions that haven't declared compatibilitymicrosoft/security-devops-actionhas no such requirement on hosted runners, with a pointer to its docs for self-hosted runner guidanceOriginal prompt