Skip to content

fix: add explicit greenlet dependency for SQLAlchemy async support #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
szerintedmi wants to merge 1 commit into from
Closed

fix: add explicit greenlet dependency for SQLAlchemy async support #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ dependencies = [
"python-multipart>=0.0.6",
"pydantic-settings>=2.1.0",
"sqlalchemy>=2.0.23",
"greenlet>=3.0.0",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better long-term maintainability, it's good practice to add a comment explaining why this explicit dependency is needed. This helps future developers understand the context without having to dig through git history. greenlet is required for SQLAlchemy's async support but isn't always installed as a transitive dependency, which is not immediately obvious.

Suggested change
"greenlet>=3.0.0",
# Required for SQLAlchemy async support (e.g., with aiosqlite)
"greenlet>=3.0.0",

"aiosqlite>=0.19.0",
"alembic>=1.13.0",
"passlib[bcrypt]>=1.7.4",
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"python-multipart>=0.0.6",
"pydantic-settings>=2.1.0",
"sqlalchemy>=2.0.23",
"greenlet>=3.0.0",
"aiosqlite>=0.19.0",
"alembic>=1.13.0",
"passlib[bcrypt]>=1.7.4",
Expand Down