Repo hardening: fix install instructions, dead imports, hygiene - #1
Open
cognis-digital wants to merge 5 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#1cognis-digital wants to merge 5 commits into
cognis-digital wants to merge 5 commits into
Conversation
- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install) - remove 3 unused import(s) (ruff F401/F811)
cognis-digital
force-pushed
the
cognis-audit/repo-hardening
branch
from
June 12, 2026 21:57
5f9a078 to
5d4e01d
Compare
…-06-13) - README install instructions point at the working git+https path - ran the actual audit: 14 tests passed, 0 parse errors, CLI C:\Python314\python.exe: No module named https - embedded results in README ## Verification and AUDIT.md
- layman.md: 4-sentence plain-English description of what optout does - README.md: insert "What is this?" section and comprehensive Install section (managed with cognis:layman/install sentinels; idempotent) - install.sh: comprehensive POSIX installer (pipx→uv→pip→source) - install.ps1: comprehensive Windows PowerShell installer
- load_profile now raises FileNotFoundError (with message) for missing files, ValueError with clear text for malformed JSON and non-object payloads, and OSError for unreadable files; previously any of these produced a raw traceback. - build_requests raises ValueError on an empty only=[] list (was silently treating it as "no filter"); get_broker None results are now filtered out defensively before iteration. - render_letter guards against a None broker argument. - render_all skips broker-slug lookup failures defensively. - summarize maps unknown status values to "pending" rather than accumulating them outside the known-status keys. - cli.py main() catches OSError in addition to FileNotFoundError so permission-denied and similar I/O errors surface as "error: ..." messages instead of tracebacks. - webhook.py: fix E401 (split multi-import), validate --url scheme, and reject empty stdin before making the network request. - Add tests/test_hardening.py with 16 new tests covering all new error paths and edge cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.