feat: v9 merge in latest & drop hardcoded PageHeader/Footer heights#513
Draft
feat: v9 merge in latest & drop hardcoded PageHeader/Footer heights#513
Conversation
…508) - Add --html flag to the audit-figma-integration command to generate the HTML report - Copy the date-stamped report to index.html so it's accessible at the Pages root - Add job-level permissions (pages: write, id-token: write) for Pages deployment - Add environment declaration linking the job to the github-pages environment - Add configure-pages, upload-pages-artifact, and deploy-pages steps - Allow workflow_dispatch so the audit and Pages deploy can be triggered manually Resolves CDS-1700
* feat: add freeSolo Combobox example * Add accessibility section * Fix * Update country selector * Update combobox a11y
* chore: update Checkbox borderRadius to match design * Bump version * Update changelog and exclude a11y test from percy * Include storybook test add ons when not in visreg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR merges in the latest to cds-v9 and drops PageHeader/PageFooter height const 205a5b4
There is one small change, in Figma we had a hardcoded height of 40px aroun the title, rather than relying on the 36px in height regular title. This means that any case where we have no icon but title only the height is now shorter by 4px. Design is updating on their end to match.
UI changes
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false