Skip to content

feat: Add new a11y lint rules#528

Open
maximo-macchi-cb wants to merge 11 commits intomasterfrom
max/a11y-lint-rules
Open

feat: Add new a11y lint rules#528
maximo-macchi-cb wants to merge 11 commits intomasterfrom
max/a11y-lint-rules

Conversation

@maximo-macchi-cb
Copy link
Contributor

What changed? Why?

This PR adds new accessibility lint rules and util methods for the eslint-plugin-cds package. The util methods are for general usage but so far have only been used in a11y specific lint rules. As well, the existing lint rules checking for accessibility labels have been extended to include new components.

The new rules include:

  • web-tooltip-interactive-content: Checks if the hasInteractiveContent prop is used when a <Tooltip> has interactive elements in its content prop
  • web-chart-scrubbing-accessibility: Checks if a chart has the correct a11y props when the enableScrubbing prop is true
  • mobile-chart-scrubbing-accessibility: Checks if a chart has the correct a11y props when the enableScrubbing prop is true

This PR's goal is to just add new rules and extend coverage. I will be working on another PR to clean up documentation and the package's exported config to make rule creation and plugin usage easier.

Root cause (required for bugfixes)

UI changes

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@maximo-macchi-cb maximo-macchi-cb self-assigned this Mar 20, 2026
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 20, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS 🟡 See below

🟡 CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 🟡 0/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants