Open
Conversation
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR adds new accessibility lint rules and util methods for the
eslint-plugin-cdspackage. The util methods are for general usage but so far have only been used in a11y specific lint rules. As well, the existing lint rules checking for accessibility labels have been extended to include new components.The new rules include:
web-tooltip-interactive-content: Checks if thehasInteractiveContentprop is used when a<Tooltip>has interactive elements in itscontentpropweb-chart-scrubbing-accessibility: Checks if a chart has the correct a11y props when theenableScrubbingprop istruemobile-chart-scrubbing-accessibility: Checks if a chart has the correct a11y props when theenableScrubbingprop istrueThis PR's goal is to just add new rules and extend coverage. I will be working on another PR to clean up documentation and the package's exported config to make rule creation and plugin usage easier.
Root cause (required for bugfixes)UI changesTesting
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false