Skip to content

Fix: properly await async package updates#529

Open
nikolaysamoil0ff wants to merge 1 commit intocoinbase:masterfrom
nikolaysamoil0ff:nikolaysamoil0ff-patch-1
Open

Fix: properly await async package updates#529
nikolaysamoil0ff wants to merge 1 commit intocoinbase:masterfrom
nikolaysamoil0ff:nikolaysamoil0ff-patch-1

Conversation

@nikolaysamoil0ff
Copy link

What changed? Why?

Replaced forEach with an async-aware loop to ensure all package updates are awaited before the script completes.

This prevents premature completion and ensures errors are properly propagated.

Root cause (required for bugfixes)

UI changes

iOS Old iOS New
old screenshot new screenshot
Android Old Android New
old screenshot new screenshot
Web Old Web New
old screenshot new screenshot

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

Replaced forEach with an async-aware loop to ensure all package updates are awaited before the script completes.

This prevents premature completion and ensures errors are properly propagated.
@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS 🟡 See below

🟡 CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 🟡 0/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants