Skip to content

feat: customize radio controlSize & dotSize#546

Draft
hcopp wants to merge 2 commits intomasterfrom
hunte/customize-radio-size
Draft

feat: customize radio controlSize & dotSize#546
hcopp wants to merge 2 commits intomasterfrom
hunte/customize-radio-size

Conversation

@hcopp
Copy link
Contributor

@hcopp hcopp commented Mar 25, 2026

What changed? Why?

This PR adds controlSize and dotSize to Radio on web. On mobile we add it to Control since that is how the components are configured, but we omit from Switch and Checkbox.

UI changes

Custom borderWidth before and then after with our adjusted dotSize.

iOS Old iOS New
image image
Web Old Web New
image image

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 25, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS 🟡 See below

🟡 CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 🟡 0/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

export type CheckboxBaseProps<CheckboxValue extends string> = Omit<
ControlBaseProps<CheckboxValue>,
'controlColor'
'controlColor' | 'controlSize' | 'dotSize'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is frustrating how we currently do control on mobile, I think we should refactor to match web style in the future. Unless there is a good reason I'm not aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants