Draft
Conversation
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
hcopp
commented
Mar 25, 2026
| export type CheckboxBaseProps<CheckboxValue extends string> = Omit< | ||
| ControlBaseProps<CheckboxValue>, | ||
| 'controlColor' | ||
| 'controlColor' | 'controlSize' | 'dotSize' |
Contributor
Author
There was a problem hiding this comment.
It is frustrating how we currently do control on mobile, I think we should refactor to match web style in the future. Unless there is a good reason I'm not aware of.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR adds controlSize and dotSize to Radio on web. On mobile we add it to Control since that is how the components are configured, but we omit from Switch and Checkbox.
UI changes
Custom borderWidth before and then after with our adjusted dotSize.
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false