-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add purgeRuns API and retainRuns auto-cleanup option #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f2223c0
feat: add purgeRuns API and retainRuns auto-cleanup option
coji bceeff6
refactor: simplify purge implementation per review
coji 5e31d32
refactor: consolidate purge index into migration v1
coji 78de639
fix: address simplify review findings
coji 23b217f
perf: remove redundant getRuns({ status: 'leased' }) from processOne …
coji 1b7d71b
docs: add purgeRuns and retainRuns to website API reference
coji cbb6cdb
docs: fix purgeRuns signature — olderThan is required Date, not optio…
coji 85a366c
fix: address CodeRabbit review findings
coji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import { createNodeDialect } from '../helpers/node-dialect' | ||
| import { createPurgeTests } from '../shared/purge.shared' | ||
|
|
||
| createPurgeTests(createNodeDialect) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't fold new DDL into migration 1.
Line 12 still leaves
LATEST_SCHEMA_VERSIONat1, so databases that already recorded version 1 will skip this block forever. Existing installs won't getidx_durably_runs_status_completed, which means the new purge query loses its supporting index.💡 Safer migration shape
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentionally kept in v1. This library has no production databases yet — we explicitly consolidated all migrations into v1 earlier in this PR to avoid carrying dead migration versions. The
ifNotExistsguard makes it safe for any edge case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coji, understood — thanks for the context. A clean consolidation into v1 while the library is still pre-production is a perfectly reasonable approach, and theifNotExistsguard ensures idempotency for any edge cases. I'll stand down on this one.✏️ Learnings added
🧠 Learnings used