Make cuffmerge Python 3 compatible#108
Open
chenghlee wants to merge 2 commits intocole-trapnell-lab:masterfrom
Open
Make cuffmerge Python 3 compatible#108chenghlee wants to merge 2 commits intocole-trapnell-lab:masterfrom
cuffmerge Python 3 compatible#108chenghlee wants to merge 2 commits intocole-trapnell-lab:masterfrom
Conversation
added 2 commits
January 4, 2019 23:28
Used `2to3` to help improve `cuffmerge`'s Python-3 compatibility. Mostly, this involved fixing `print`s and the syntax for `except` statements. Also, one `.iteritems()` and one `isinstance()` **WARNING**: `cuffmerge` is still not fully Py3-compatible, as we still need to deal with the `os.tmpnam()` function being removed from the Python 3 Standard Library. Partially fixes #1.
`os.tmpnam()` was removed from the Python 3 Standard Library. `tempfile.mktemp()` is functionally equivalent and exists in both the Python 2.7 and 3 Standard Libraries (though it too has been declared deprecated). This should be the final tweak necessary needed to make `cuffmerge` compatible with both Python 2 and 3 compatible. Fixes #1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.