collector.py:147
sdata = subscription.collector_data
name = 'selected_collectors'
if name in sdata and sdata[name] and self not in sdata[name]:
return [], now
if sdata[name] is a empty list then then the above code makes the assumption that the subscription is subscribed to everything - this does seem to be rather over-assuming since an empty list is more likely to mean explicitly not subscribed to anything. Suggest changing it to
sdata = subscription.collector_data
name = 'selected_collectors'
if name in sdata and self not in sdata[name]:
return [], now
collector.py:147
if sdata[name] is a empty list then then the above code makes the assumption that the subscription is subscribed to everything - this does seem to be rather over-assuming since an empty list is more likely to mean explicitly not subscribed to anything. Suggest changing it to