Registers templates with setuptools#39
Conversation
There was a problem hiding this comment.
We don't need another singleton, python module is already a singleton.
Doing following would be enough:
templates_registry = TemplatesRegistry()
And then using that object everywhere.
|
Okay, I just re-pushed the stuff after having incorporated / merging your latest changes. It should be easier from now to include the pull request. Sorry for all this. |
|
Seems like this made it even worse, can you try to rebase the commits on top of current master? |
Conflicts: docs/source/userguide.rst mrbob/cli.py
|
Hi, I included in my master your latest changes. pulling from my repo should not suck as before :) |
|
Will review this and merge, as soon as I find time |
|
You can test the new feature with bobtemplates.gillux that's already registering its 2 templates the setuptools way. |
|
Ah, this is taking ages, will try to get to it in next days. |
|
BTW, I introduced in the last changes the fix for Windows users. See #49 |
|
@glenfant nop, just didn't get to it yet. Some PEP8 is failing, would you mind fixing that? |
|
I just released 0.1, this will probably be part of 0.2 |
|
@domenkozar You closed the related issue but did nor merge. What is the plan ? |
4 participants
See issue #37 for details.