no postError field existance on non-fields#1381
Open
peterjanssens wants to merge 1 commit intocollectiveaccess:dev/php8from
Open
no postError field existance on non-fields#1381peterjanssens wants to merge 1 commit intocollectiveaccess:dev/php8from
peterjanssens wants to merge 1 commit intocollectiveaccess:dev/php8from
Conversation
Owner
|
Hmm, there's more to this I think. I'll investigate. |
Contributor
Author
|
14 is the identifier for the (standard) editor ui, not sure yet where the 21 points to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when debug_output enabled we get postErrors on non-errors.
in this case going from a set to the batch editor the BaseModel is loaded for instance with pm_id array(2) { [21]=> int(28) ["all"]=> int(14) }
The condition here is tested for vs_field 21 that is not a field. It is probably 'correct' that is not a field, but not important feedback either ?
I'm guessing here that the routine can be exited too, so kept the return (false) as-is