Open
Conversation
41851a7 to
e629d34
Compare
This will enable the ability to link to an image via URL only at this stage, but allow the user to style their images. The CKEditor5 CSS needs to be added to Pawtucket theme to allow for this.
This will hopefully allow the HTML 5 elements needed for image insertion without needing to fully disable HTMLPurifier. I will be looking at trying out the HTMLPurifier Plugin at https://github.com/xemlock/htmlpurifier-html5
15d88da to
cb22893
Compare
Contributor
Author
|
Since this pull request, I have done more work on the ck-editor plugin. I will leave this as is for the moment, but will be creating another one or two pull requests over the coming days. One is for the HTMLPurifier to accept more HTML5 elements and the other is one that includes a wider variety of ck-editor elements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables users to both add images via URL and style them (Add caption, Alt Text, positioning and sizing).
For the image styling to work, you need to disable htmlpurifier in its current form, as it doesn't support HTML5. Suggest moving to the newer htmlpurifier with HTML5 definitions library: https://github.com/xemlock/htmlpurifier-html5 as ezyang has refused to support html5
For pawtucket to style the images correctly, the
ck-contentclass needs to be added to blocks with ckeditor content.Also a few extra clean ups, like using a separator, adding highlighting and special characters. Turned on grouping, to make the editor tidier. Resizable was missing from the htmlFormHelper.
If it helps. This is the editor toolbar config I have been using:
I didn't change it in this commit, not knowing how many out there use the default outlay, but feel free to update it if you think it's a better structure.
Future development: