guard against null for array_keys#1840
Open
peterjanssens wants to merge 1 commit intocollectiveaccess:dev/2.0from
Open
guard against null for array_keys#1840peterjanssens wants to merge 1 commit intocollectiveaccess:dev/2.0from
peterjanssens wants to merge 1 commit intocollectiveaccess:dev/2.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we experienced the same as #1839
it comes down to the $va_to_display_items being null after cancel instead of an empty array, this fix does the null coalescing.
After that the we have a sort of empty search form again (without any selectable items however - maybe it is better to redirect the cancel to the search form list instead ? other variables seem lacking there like search type [1103] error, but probably not that relevant when landing on a blanked search form)