Skip to content

filter current user from other users#1853

Open
peterjanssens wants to merge 1 commit intocollectiveaccess:dev/2.0from
libis:fix/other_user_sets
Open

filter current user from other users#1853
peterjanssens wants to merge 1 commit intocollectiveaccess:dev/2.0from
libis:fix/other_user_sets

Conversation

@peterjanssens
Copy link
Contributor

when browsing sets some users are troubled by seeing their own sets listed among the "by other users" functionality.

There are a few inconsistencies still (like the 'allUsers' option key, and the navigation manage>my sets>All sets vs User Sets) but since you can have your own sets listed separately, it would make sense to have the other users sets separately (without the noise of your own sets) ?

@collectiveaccess
Copy link
Owner

Or we can just relabel the option "all sets"

@peterjanssens
Copy link
Contributor Author

there is already pa_options['all'] on condition up (in reality "my" ?), the pa_options['allUsers'] then seems redundant (could be 'other' ?).

Same for the navigation (menubar) where there are "all sets" and "sets by user", the third option "user sets" would make more sense as "sets by other users". Haven't seen "public" (no user?) sets in the wild yet.

In the actual set listing view (manage/Set/ListSets), there is "available to you" what comes down to "sets by user" no ? All (sub)sets (user, other, any) are available to me .. the aggregation (sum) of "all sets" is not really one of the options I think ?? When you navigate "all sets" in the menubar you seem to land on the "my sets"-subset.

Currently "other" is kind of "all" (think without public since that condition uses user_ids). So there is no real "all", but I think most people would be fine with the three subsets : my/other/public ??

Sorry if I'm stirring confusion :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants