fix: prevent connection storms and MaxConns violations in pgxpool (Fixes #3) - #6
Open
laurentketterle-hub wants to merge 1 commit into
Open
fix: prevent connection storms and MaxConns violations in pgxpool (Fixes #3)#6laurentketterle-hub wants to merge 1 commit into
laurentketterle-hub wants to merge 1 commit into
Conversation
Track pending (in-flight) connection attempts and ensure activeCount + inFlightConns never exceeds MaxConns. Goroutines now block on a sync.Cond instead of racing to dial, which eliminates connection storms during database recovery. - Add inFlightConns atomic tracking to Pool - Condition-variable based Acquire with capacity check - Safe decrement of inFlightConns on dial failure - Comprehensive tests (6/6 pass): * MaxConns respect under concurrency * Blocking at capacity + unblock on release * Pending counter decrement on failure * Context cancellation * Sequential acquire/release * Dial failure decrement correctness Closes colmev080#3 Signed-off-by: laurentketterle-hub <noreply@users.noreply.github.com>
|
😅 Unfortunately there are no rewards left to claim in this issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
Prevent connection storms and MaxConns violations in pgxpool during database recovery.
Changes
What was the problem?
During PostgreSQL recovery, multiple goroutines blocked on would simultaneously observe pool capacity available and race to dial, creating connection storms that could exhaust .
Tests (6/6 pass)
/claim #3